Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752736AbcJEMwf (ORCPT ); Wed, 5 Oct 2016 08:52:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:58490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbcJEMwe (ORCPT ); Wed, 5 Oct 2016 08:52:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <1474898801-36571-1-git-send-email-navam@xilinx.com> <20161003184234.GA13165@rob-hp-laptop> From: Rob Herring Date: Wed, 5 Oct 2016 07:52:09 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5] devicetree: bindings: uart: Add new compatible string for ZynqMP To: Nava kishore Manne Cc: "gregkh@linuxfoundation.org" , "mark.rutland@arm.com" , "jslaby@suse.com" , "michal.simek@xilinx.com" , Soren Brinkmann , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Punnaiah Choudary Kalluri Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 44 On Wed, Oct 5, 2016 at 7:23 AM, Nava kishore Manne wrote: > Hi Rob, > > Thanks for the review... > >> > Changes for v5: >> > -Fixed some minor comments. >> >> Not a useful changelog. The point of these comments is to remind the >> reviewers of what they commented on. > > Ok will take care from next version onwards... > >> > Required properties: >> > -- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps" >> > +- compatible : >> > + Use "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq-7xxx SoC. >> >> This is still not right. It was wrong before, but you are touching it so make it >> right. >> >> OR doesn't match the dts files. It is AND and the opposite order. >> >> xlnx,xuartps wasn't the best naming, but it's in use so we'll have to live with it >> for zynq-7xxx. >> >> > + Use "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC. >> >> What I meant here was this should have something like "xlnx,mpsoc-uart" >> as the first compatible with "cdns,uart-r1p12" as the second. Not sure if >> "mpsoc" is the best name here. > > You mean something like below > Use "xlnx,xuartps" or "cdns,uart-r1p8" for Zynq-7xxx SoC. As I said, it is not an OR condition. 'Use "xlnx,xuartps", "cdns,uart-r1p8" for Zynq-7xxx SoC > Use "xlnx,zynqmp-uart" or " cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC. Yes, but as above. Rob