Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754473AbcJEP4C (ORCPT ); Wed, 5 Oct 2016 11:56:02 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:36006 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754069AbcJEP4A (ORCPT ); Wed, 5 Oct 2016 11:56:00 -0400 Date: Wed, 5 Oct 2016 11:55:58 -0400 From: Tejun Heo To: zijun_hu Cc: Andrew Morton , zijun_hu@htc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cl@linux.com Subject: Re: [RFC PATCH v3 2/2] mm/percpu.c: fix potential memory leakage for pcpu_embed_first_chunk() Message-ID: <20161005155558.GE26977@htj.duckdns.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 517 Lines: 15 On Wed, Oct 05, 2016 at 09:30:24PM +0800, zijun_hu wrote: > From: zijun_hu > > in order to ensure the percpu group areas within a chunk aren't > distributed too sparsely, pcpu_embed_first_chunk() goes to error handling > path when a chunk spans over 3/4 VMALLOC area, however, during the error > handling, it forget to free the memory allocated for all percpu groups by > going to label @out_free other than @out_free_areas. Applied 1-2 to percpu/for-4.9. Thanks for the persistence! -- tejun