Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754512AbcJERH6 (ORCPT ); Wed, 5 Oct 2016 13:07:58 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:33004 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbcJERH4 (ORCPT ); Wed, 5 Oct 2016 13:07:56 -0400 MIME-Version: 1.0 In-Reply-To: <1475686858.6105.7.camel@perches.com> References: <20161004093216.GA21170@cmpxchg.org> <20161005092534.GA20174@cmpxchg.org> <1475686858.6105.7.camel@perches.com> From: Linus Torvalds Date: Wed, 5 Oct 2016 10:07:55 -0700 X-Google-Sender-Auth: dOGf-1m3QTgZSCSEPIKtvCP-nPg Message-ID: Subject: Re: [PATCH] checkpatch: extend BUG warning To: Joe Perches Cc: Johannes Weiner , Andy Whitcroft , Andrew Morton , Antonio SJ Musumeci , Miklos Szeredi , Dave Jones , Oleg Nesterov , Dave Chinner , Michal Hocko , Jan Kara , Linux Kernel Mailing List , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 570 Lines: 14 On Wed, Oct 5, 2016 at 10:00 AM, Joe Perches wrote: > 1838 BUILD_BUG_ON > 632 snd_BUG_ON At least snd_BUG_ON() is actually fine. The sound system does something sane with their bugs: they just turn into WARN_ON()'s (and then !CONFIG_SND_DEBUG will disable them entirely). I haven't checked the other ones, but it was actually nice to see that one: considering that it's the most widely used one (ignoring the obviously great BUILD_BUG_ON), the fact that it just spews a warning indicates that that model works fine. Linus