Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754214AbcJESzk (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Oct 2016 14:55:40 -0400
Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:53679
        "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752437AbcJESzj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Oct 2016 14:55:39 -0400
Date: Wed, 5 Oct 2016 15:55:32 -0300
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: Jiri Kosina <jikos@kernel.org>,
        Patrick Boettcher <patrick.boettcher@posteo.de>,
        =?UTF-8?B?SsO2cmc=?= Otte <jrg.otte@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Michael Krufky <mkrufky@linuxtv.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: Problem with VMAP_STACK=y
Message-ID: <20161005155532.682258e2@vento.lan>
In-Reply-To: <20161005182945.nkpphvd6wtk6kq7h@linuxtv.org>
References: <CADDKRnB1=-zj8apQ3vBfbxVZ8Dc4DJbD1MHynC9azNpfaZeF6Q@mail.gmail.com>
        <alpine.LRH.2.00.1610041519160.1123@gjva.wvxbf.pm>
        <CADDKRnA1qjyejvmmKQ9MuxH6Dkc7Uhwq4BSFVsOS3U-eBWP9GA@mail.gmail.com>
        <alpine.LNX.2.00.1610050925470.31629@cbobk.fhfr.pm>
        <20161005093417.6e82bd97@vdr>
        <alpine.LNX.2.00.1610050947380.31629@cbobk.fhfr.pm>
        <20161005060450.1b0f2152@vento.lan>
        <20161005182945.nkpphvd6wtk6kq7h@linuxtv.org>
Organization: Samsung
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1710
Lines: 59

Hi Johannes,

Em Wed, 5 Oct 2016 20:29:45 +0200
Johannes Stezenbach <js@linuxtv.org> escreveu:

> On Wed, Oct 05, 2016 at 06:04:50AM -0300, Mauro Carvalho Chehab wrote:
> >  static int cinergyt2_frontend_attach(struct dvb_usb_adapter *adap)
> >  {
> > -	char query[] = { CINERGYT2_EP1_GET_FIRMWARE_VERSION };
> > -	char state[3];
> > +	struct dvb_usb_device *d = adap->dev;
> > +	struct cinergyt2_state *st = d->priv;
> >  	int ret;
> >  
> >  	adap->fe_adap[0].fe = cinergyt2_fe_attach(adap->dev);
> >  
> > -	ret = dvb_usb_generic_rw(adap->dev, query, sizeof(query), state,
> > -				sizeof(state), 0);  
> 
> it seems to miss this:
> 
> 	st->data[0] = CINERGYT2_EP1_GET_FIRMWARE_VERSION;
> 
> > +	ret = dvb_usb_generic_rw(d, st->data, 1, st->data, 3, 0);
> >  	if (ret < 0) {
> >  		deb_rc("cinergyt2_power_ctrl() Failed to retrieve sleep "
> >  			"state info\n");
> > @@ -141,13 +147,14 @@ static int repeatable_keys[] = {
> >  static int cinergyt2_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
> >  {
> >  	struct cinergyt2_state *st = d->priv;
> > -	u8 key[5] = {0, 0, 0, 0, 0}, cmd = CINERGYT2_EP1_GET_RC_EVENTS;
> >  	int i;
> >  
> >  	*state = REMOTE_NO_KEY_PRESSED;
> >  
> > -	dvb_usb_generic_rw(d, &cmd, 1, key, sizeof(key), 0);
> > -	if (key[4] == 0xff) {
> > +	st->data[0] = CINERGYT2_EP1_SLEEP_MODE;  
> 
> should probably be
> 
> 	st->data[0] = CINERGYT2_EP1_GET_RC_EVENTS;
> 
> > +
> > +	dvb_usb_generic_rw(d, st->data, 1, st->data, 5, 0);  
> 
> 
> HTH,
> Johannes


Thanks for the review! Yeah, you're right: both firmware and remote
controller logic would be broken without the above fixes.

Just sent a version 2 of this patch to the ML with the above fixes.

Regards,
Mauro