Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793AbcJEUEL (ORCPT ); Wed, 5 Oct 2016 16:04:11 -0400 Received: from mail.kernel.org ([198.145.29.136]:34928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753120AbcJEUEJ (ORCPT ); Wed, 5 Oct 2016 16:04:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <1474660869-15532-1-git-send-email-zach.brown@ni.com> <1474660869-15532-2-git-send-email-zach.brown@ni.com> From: Rob Herring Date: Wed, 5 Oct 2016 15:03:44 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 1/2] sdhci: Add device tree property sd-broken-highspeed To: Ulf Hansson Cc: Zach Brown , Adrian Hunter , Mark Rutland , linux-mmc , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1805 Lines: 40 On Wed, Oct 5, 2016 at 1:33 PM, Ulf Hansson wrote: > On 23 September 2016 at 22:01, Zach Brown wrote: >> Certain board configurations can make highspeed malfunction due to >> timing issues. In these cases a way is needed to force the controller >> and card into standard speed even if they otherwise appear to be capable >> of highspeed. >> >> The sd-broken-highspeed property will let the sdhci driver know that >> highspeed will not work. >> >> Signed-off-by: Zach Brown >> --- >> Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt >> index 8a37782..59332ea 100644 >> --- a/Documentation/devicetree/bindings/mmc/mmc.txt >> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt >> @@ -52,6 +52,8 @@ Optional properties: >> - no-sdio: controller is limited to send sdio cmd during initialization >> - no-sd: controller is limited to send sd cmd during initialization >> - no-mmc: controller is limited to send mmc cmd during initialization >> +- sd-broken-highspeed: Highspeed is broken, even if the controller and card >> + themselves claim they support highspeed. > > Regarding a broken card, that is managed via the card quirks and not in DT. > > If this is about a controller limitation, we already have the option > to describe what it supports, so we don't need an option to tell what > it *not* supports. > > For example "cap-sd-highspeed" tells whether the controller supports > SD high-speed, please use that instead. If a controller has a capability register and it lies (perhaps the board has limitations that the SoC does not), then you may need to disable a feature. Rob