Subject: Re: [PATCH] fs/block_dev.c: return the right error in thaw_bdev()
To: Jan Kara <jack@suse.cz>, Pierre Morel <pmorel@linux.vnet.ibm.com>
References: <1475571220-2522-1-git-send-email-pmorel@linux.vnet.ibm.com>
 <1475571220-2522-2-git-send-email-pmorel@linux.vnet.ibm.com>
 <20161004090615.GF17515@quack2.suse.cz>
CC: <viro@zeniv.linux.org.uk>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <mguzik@redhat.com>,
        <farman@linux.vnet.ibm.com>, <cornelia.huck@de.ibm.com>
From: Jens Axboe <axboe@fb.com>
Message-ID: <b9661487-676a-ac3f-43b3-8559e88af06f@fb.com>
Date: Wed, 5 Oct 2016 14:35:33 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20161004090615.GF17515@quack2.suse.cz>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2016 20:35:38.1312 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1188
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-05_05:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 696
Lines: 21

On 10/04/2016 03:06 AM, Jan Kara wrote:
> On Tue 04-10-16 10:53:40, Pierre Morel wrote:
>> When triggering thaw-filesystems via magic sysrq, the system enters a
>> loop in do_thaw_one(), as thaw_bdev() still returns success if
>> bd_fsfreeze_count == 0. To fix this, let thaw_bdev() always return
>> error (and simplify the code a bit at the same time).
>>
>> Reviewed-by: Eric Farman <farman@linux.vnet.ibm.com>
>> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
>
> The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Jens, can you please merge this patch? Thanks!

Added, thanks all.

-- 
Jens Axboe