Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbcJEVLQ (ORCPT ); Wed, 5 Oct 2016 17:11:16 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:55348 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750700AbcJEVLP (ORCPT ); Wed, 5 Oct 2016 17:11:15 -0400 Date: Wed, 5 Oct 2016 23:11:09 +0200 From: Samuel Thibault To: Jitendra Khasdev Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, gregkh@linuxfoundation.org, bankarsandhya512@gmail.com, saurabh.truth@gmail.com, amitoj1606@gmail.com, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: speakup: Replaced obsolete simple_strtoul Message-ID: <20161005211109.GD7253@var> Mail-Followup-To: Samuel Thibault , Jitendra Khasdev , w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, gregkh@linuxfoundation.org, bankarsandhya512@gmail.com, saurabh.truth@gmail.com, amitoj1606@gmail.com, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1475699578-31474-1-git-send-email-jkhasdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475699578-31474-1-git-send-email-jkhasdev@gmail.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 483 Lines: 19 Hello, Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote: > From: Jitendra Kumar Khasdev > > This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch. > + unsigned long val; > + > + if (kstrtoul(start, 10, &val)) > + return NULL; > > - val = simple_strtoul(skip_spaces(start), &start, 10); > if (*start == ',') simple_strtoul modifies start, so you can't just replace it with kstrtoul. Samuel