Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754011AbcJEVxq (ORCPT ); Wed, 5 Oct 2016 17:53:46 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:64301 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751128AbcJEVxp (ORCPT ); Wed, 5 Oct 2016 17:53:45 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Wed, 5 Oct 2016 22:53:36 +0100 From: Chris Wilson To: Paulo Zanoni Cc: Lyude , intel-gfx@lists.freedesktop.org, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values Message-ID: <20161005215336.GA28048@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Paulo Zanoni , Lyude , intel-gfx@lists.freedesktop.org, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1475681598-12081-1-git-send-email-cpaul@redhat.com> <1475681598-12081-6-git-send-email-cpaul@redhat.com> <1475703844.2381.74.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1475703844.2381.74.camel@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1067 Lines: 27 On Wed, Oct 05, 2016 at 06:44:04PM -0300, Paulo Zanoni wrote: > Em Qua, 2016-10-05 ?s 11:33 -0400, Lyude escreveu: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index dd15ae2..c580d3d 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -3378,6 +3378,8 @@ static void skylake_update_primary_plane(struct > > drm_plane *plane, > > ? struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state- > > >base.crtc); > > ? struct drm_framebuffer *fb = plane_state->base.fb; > > ? const struct skl_wm_values *wm = &dev_priv->wm.skl_results; > > + const struct skl_plane_wm *p_wm = > > + &crtc_state->wm.skl.optimal.planes[0]; > > I wish someone would do a patch to convert all these hardcoded values > to PLANE_X, and convert "int"s ?to "enum plane"s everywhere. Note that this is not PLANE_A, but setting up a shorthand local for const struct skl_plane_wm *p_wm = crtc_state->wm.skl.optimal.planes; -Chris -- Chris Wilson, Intel Open Source Technology Centre