Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S262927AbTC0Ngk>; Thu, 27 Mar 2003 08:36:40 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S262929AbTC0Ngk>; Thu, 27 Mar 2003 08:36:40 -0500
Received: from pizda.ninka.net ([216.101.162.242]:19939 "EHLO pizda.ninka.net")
	by vger.kernel.org with ESMTP id <S262927AbTC0Ngj>;
	Thu, 27 Mar 2003 08:36:39 -0500
Date: Thu, 27 Mar 2003 05:43:57 -0800 (PST)
Message-Id: <20030327.054357.17283294.davem@redhat.com>
To: shmulik.hen@intel.com
Cc: dane@aiinet.com, bonding-devel@lists.sourceforge.net,
       bonding-announce@lists.sourceforge.net, netdev@oss.sgi.com,
       linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
       torvalds@transmeta.com, mingo@redhat.com, kuznet@ms2.inr.ac.ru
Subject: Re: BUG or not? GFP_KERNEL with interrupts disabled.
From: "David S. Miller" <davem@redhat.com>
In-Reply-To: <Pine.LNX.4.44.0303271406230.7106-100000@jrslxjul4.npdj.intel.com>
References: <E791C176A6139242A988ABA8B3D9B38A01085638@hasmsx403.iil.intel.com>
	<Pine.LNX.4.44.0303271406230.7106-100000@jrslxjul4.npdj.intel.com>
X-FalunGong: Information control.
X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 778
Lines: 19

   From: shmulik.hen@intel.com
   Date: Thu, 27 Mar 2003 15:32:02 +0200 (IST)

   Further more, holding a lock_irq doesn't mean bottom halves are disabled
   too, it just means interrupts are disabled and no *new* softirq can be
   queued. Consider the following situation:
   
I think local_bh_enable() should check irqs_disabled() and honour that.
What you are showing here, that BH's can run via local_bh_enable()
even when IRQs are disabled, is a BUG().

IRQ disabling is meant to be stronger than softint disabling.

Ingo/Linus?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/