Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755092AbcJEWrZ (ORCPT ); Wed, 5 Oct 2016 18:47:25 -0400 Received: from mail.kernel.org ([198.145.29.136]:41450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754986AbcJEWrU (ORCPT ); Wed, 5 Oct 2016 18:47:20 -0400 Date: Wed, 5 Oct 2016 19:47:06 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: sukadev@linux.vnet.ibm.com, jolsa@redhat.com, linux-kernel@vger.kernel.org, Andi Kleen , wangnan0@huawei.com Subject: Re: [PATCH 1/3] perf, tools: Handle events including .c and .o Message-ID: <20161005224706.GK30363@kernel.org> References: <1475696832-9188-1-git-send-email-andi@firstfloor.org> <1475696832-9188-2-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475696832-9188-2-git-send-email-andi@firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 42 Em Wed, Oct 05, 2016 at 12:47:10PM -0700, Andi Kleen escreveu: > From: Andi Kleen > > This is a generic bug fix, but it helps with Sukadev's JSON event tree > where such events can happen. > > Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading > and then an error. This can happen for some Intel JSON events, which cannot > be used. > > Fix the scanner to only match for .o or .c or .bpf at the end. > This will prevent loading multiple BPF scripts separated with comma, > but I assume this is acceptable. Wang, may I have your Acked-by, please? - Arnaldo > Cc: wangnan0@huawei.com > Cc: sukadev@linux.vnet.ibm.com > Signed-off-by: Andi Kleen > --- > tools/perf/util/parse-events.l | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 9f43fda2570f..377147088a46 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -183,8 +183,8 @@ modifier_bp [rwx]{1,3} > } > > {event_pmu} | > -{bpf_object} | > -{bpf_source} | > +({bpf_object}$) | > +({bpf_source}$) | > {event} { > BEGIN(INITIAL); > REWIND(1); > -- > 2.5.5