Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934534AbcJFCMZ (ORCPT ); Wed, 5 Oct 2016 22:12:25 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:35030 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274AbcJFCMX (ORCPT ); Wed, 5 Oct 2016 22:12:23 -0400 MIME-Version: 1.0 In-Reply-To: <20161006015957.GB9806@dastard> References: <20161006015957.GB9806@dastard> From: Linus Torvalds Date: Wed, 5 Oct 2016 19:12:21 -0700 X-Google-Sender-Auth: rv_tL965LTR6FBmMHPDxbcQoOH8 Message-ID: Subject: Re: BUG_ON() in workingset_node_shadows_dec() triggers To: Dave Chinner Cc: Paul Gortmaker , Johannes Weiner , Andrew Morton , Antonio SJ Musumeci , Miklos Szeredi , Linux Kernel Mailing List , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 20 On Wed, Oct 5, 2016 at 6:59 PM, Dave Chinner wrote: > > In XFS, we use ASSERT() (could be XFS_BUG_ON() for all > that the name matters) but we only define that to BUG_ON if > CONFIG_XFS_DEBUG=y. > > For "production debug" kernels we have CONFIG_XFS_WARN=y, which > turns ASSERT() into WARN_ON(). We get the warnings, but none of the > crashiness that are desirable in a development context. Yes. that sounds very much like the right kind of decision. Forcing crashes can be very useful for the actual developer that is doing development on the code itself, kind of a "fail fast, fail hard". But users (or developers that are developing something _else_ than XFS ;) don't tend to like it. Linus