Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbcJFEbq (ORCPT ); Thu, 6 Oct 2016 00:31:46 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33486 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbcJFEbn (ORCPT ); Thu, 6 Oct 2016 00:31:43 -0400 Date: Thu, 6 Oct 2016 13:31:39 +0900 From: Sergey Senozhatsky To: Eric Dumazet Cc: Michal Sojka , Sergey Senozhatsky , Aaron Conole , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell , Florian Westphal , Pablo Neira Ayuso , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Sergey Senozhatsky Subject: Re: error: 'struct net_device' has no member named 'nf_hooks_ingress' Message-ID: <20161006043139.GB5458@swordfish> References: <20160927164026.741b290b@canb.auug.org.au> <20160927100324.GA466@swordfish> <20161004004801.GA4661@swordfish> <87wphm1pn8.fsf@steelpick.2x.cz> <1475701886.28155.223.camel@edumazet-glaptop3.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475701886.28155.223.camel@edumazet-glaptop3.roam.corp.google.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 26 On (10/06/16 06:11), Eric Dumazet wrote: > On Wed, 2016-10-05 at 22:56 +0200, Michal Sojka wrote: > > > this commit is now in mainline as > > e3b37f11e6e4e6b6f02cc762f182ce233d2c1c9d and it breaks my build: > > > > net/netfilter/core.c: In function 'nf_set_hooks_head': > > net/netfilter/core.c:96:3: error: 'struct net_device' has no member named 'nf_hooks_ingress' > > > > Are the fixes (see below) on the way to mainline too? > > Yes the fixes are already in nf tree and _will_ get pushed. > > Pablo and David are attending netdev 1.2 in Tokyo and have obligations. > > https://git.kernel.org/cgit/linux/kernel/git/pablo/nf-next.git/ well, I did my best to avoid it, but the guys didn't even bother to reply. pushing a knowingly broken patch that a) kills the build b) introduces a race c) requires two "Fixes:" followup patches to the main line despite the fact that those problems were discovered at linux-next stage is totally un-cool. -ss