Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934568AbcJFGZo (ORCPT ); Thu, 6 Oct 2016 02:25:44 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:16810 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934036AbcJFGZm (ORCPT ); Thu, 6 Oct 2016 02:25:42 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 06 Oct 2016 08:25:39 +0200 X-ME-IP: 90.5.140.104 From: Robert Jarzmik To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Sergey Yanovich , Heikki Krogerus , James Cameron , Russell King Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core References: <1474993396-525-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 06 Oct 2016 08:25:35 +0200 In-Reply-To: <1474993396-525-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Tue, 27 Sep 2016 18:23:16 +0200") Message-ID: <87shsa804g.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 41 Robert Jarzmik writes: > From: Sergey Yanovich > > pxa2xx-uart was a separate uart platform driver. It was declaring > the same device names and numbers as 8250 driver. As a result, > it was impossible to use 8250 driver on PXA SoCs. > > Upon closer examination pxa2xx-uart turned out to be a clone of > 8250_core driver. > > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor > Specification Update (April 19, 2010) is dropped. 8250_core reads > from FIFO immediately after checking DR bit in LSR. > > The patch leaves the original SERIAL_PXA driver around. The original > driver is just marked DEPRECATED in Kconfig and C source. When > the original driver is considered safe to remove, no changes > to SERIAL_8250 will be necessary. > > Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without > SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new > and the original drivers are made mutually exclusive. > > Signed-off-by: Sergei Ianovich > CC: Heikki Krogerus > CC: James Cameron > CC: Greg Kroah-Hartman > CC: Robert Jarzmik > CC: Russell King > Reviewed-by: Heikki Krogerus > [rebased on v4.8] > Tested-by: Robert Jarzmik > Signed-off-by: Robert Jarzmik Greg, can you take that into you tty tree please ? Cheers. -- Robert