Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbcJFGdk (ORCPT ); Thu, 6 Oct 2016 02:33:40 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34020 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbcJFGdj (ORCPT ); Thu, 6 Oct 2016 02:33:39 -0400 MIME-Version: 1.0 From: John Stultz Date: Wed, 5 Oct 2016 23:33:38 -0700 Message-ID: Subject: [REGRESSION] "dwc2: gadget: fix TX FIFO size and address initialization" breaks "adb logcat" on hikey To: Robert Baldyga , John Youn , Felipe Balbi Cc: lkml , Amit Pundir , Guodong Xu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 32 Hey folks, So I've run into some trouble that I've narrowed down to commit aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address initialization"). After booting up android on HiKey, if I run "adb logcat", I get about a page of logs and then I get disconnected. On the device side, I see the following in dmesg: [ 35.652076] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep ffffffc078a4c218 ep1in, 0) [ 35.660334] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep ffffffc078a4c018 ep1out, 0) After which if I stop adbd I see: [ 99.471363] dwc2 f72c0000.usb: dwc2_hsotg_ep_stop_xfr: timeout flushing fifos and if I then restart adbd on the device it will sometimes work, but not always. Reverting ba48eab8866c ("usb: dwc2: gadget: change variable name to more meaningful") and aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address initialization") makes things work again. Any thoughts as to what might be going wrong here? I'd be happy to help debug things. thanks -john