Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbcJFIAY (ORCPT ); Thu, 6 Oct 2016 04:00:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54870 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbcJFIAW (ORCPT ); Thu, 6 Oct 2016 04:00:22 -0400 Date: Thu, 6 Oct 2016 10:00:21 +0200 From: Artem Savkov To: David Howells Cc: Kirill Marinushkin , paul.gortmaker@windriver.com, james.l.morris@oracle.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Message-ID: <20161006080021.GD19785@shodan.usersys.redhat.com> References: <1473179547-12101-1-git-send-email-k.marinushkin@gmail.com> <32083.1473167516@warthog.procyon.org.uk> <25951.1473185773@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <25951.1473185773@warthog.procyon.org.uk> User-Agent: Mutt/1.7+2 (e5fcfc5f9c2e) (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 06 Oct 2016 08:00:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 18 On Tue, Sep 06, 2016 at 07:16:13PM +0100, David Howells wrote: > Kirill Marinushkin wrote: > > > IMO, the preferable fix depends on your future plan. > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with the > > patch suggested by Artem Savkov. > > If you plan to reduce using ANSI X9.31 DRNG and use DRBG more widely - I > > suggest my patch. > > No such plans, TBH. I agre with Kirill here, so if we are not trying to reduce ANSI X9.31 DRNG usage can we move on with the suggested patch, or are there any issues with it that need addressing? -- Regards, Artem