Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753226AbcJFIBk (ORCPT ); Thu, 6 Oct 2016 04:01:40 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34508 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbcJFIBh (ORCPT ); Thu, 6 Oct 2016 04:01:37 -0400 MIME-Version: 1.0 X-Originating-IP: [217.173.44.24] In-Reply-To: <20161005234928.GJ19539@ZenIV.linux.org.uk> References: <20161005195210.GC31239@veci.piliscsaba.szeredi.hu> <20161005234928.GJ19539@ZenIV.linux.org.uk> From: Miklos Szeredi Date: Thu, 6 Oct 2016 10:01:35 +0200 Message-ID: Subject: Re: [GIT PULL] overlayfs update for 4.9 To: Al Viro Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "linux-unionfs@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 27 On Thu, Oct 6, 2016 at 1:49 AM, Al Viro wrote: > On Wed, Oct 05, 2016 at 09:52:10PM +0200, Miklos Szeredi wrote: >> Hi Al, >> >> Please pull from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-viro >> >> This has an assortment of fixes and cleanups for overlayfs. >> >> It also touches the VFS: >> >> - add the vfs_get_link() helper for calling i_op->get_link(); >> - fix mnt_want_write_file() to freeze protect the underlying sb instead of >> overlay sb; >> - allow vfs_clone_file_range() to be called by overlayfs. > > Could you explain why e.g. fsetxattr() needs a different treatment in > "vfs: mnt_want_write_file() should freeze protect underlying sb"? Because setxattr is an i_op, not a f_op, so it's overlayfs that's going to be called and will do the freeze protect on underlying layer (not to mention, that it might be a different underlying sb that will get the freeze protection in the end, due to copy up) Thanks, Miklos