Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbcJFIWT (ORCPT ); Thu, 6 Oct 2016 04:22:19 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:36182 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbcJFIWR (ORCPT ); Thu, 6 Oct 2016 04:22:17 -0400 MIME-Version: 1.0 In-Reply-To: <20161006052148.GA20295@kroah.com> References: <20161005215358.GA4231@gmail.com> <20161006052148.GA20295@kroah.com> From: Nadim Almas Date: Thu, 6 Oct 2016 13:52:15 +0530 Message-ID: Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue To: Greg KH Cc: Lidza Louina , markh@compro.net, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 32 May be it is not looking better than yours but it removed 6 warning of the file which is shown by running "perl scripts/checkpatch.pl -f drivers/staging/dgnc/* | less" commend On Thu, Oct 6, 2016 at 10:51 AM, Greg KH wrote: > On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote: >> Fixed coding style issue >> >> Signed-off-by: Nadim Almas >> --- >> drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------ >> 1 file changed, 12 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h >> index abddd48..65994e3 100644 >> --- a/drivers/staging/dgnc/dgnc_neo.h >> +++ b/drivers/staging/dgnc/dgnc_neo.h >> @@ -30,7 +30,8 @@ >> struct neo_uart_struct { >> u8 txrx; /* WR RHR/THR - Holding Reg */ >> u8 ier; /* WR IER - Interrupt Enable Reg */ >> - u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */ >> + u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control */ >> + /*Reg */ > > Does that really look better now than it did before? > > I don't think so :( > > sorry, > > greg k-h