Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965992AbcJFIwF (ORCPT ); Thu, 6 Oct 2016 04:52:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48726 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965537AbcJFIwC (ORCPT ); Thu, 6 Oct 2016 04:52:02 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Will Deacon , Catalin Marinas Subject: [PATCH 4.4 18/93] drivers/perf: arm_pmu: Fix leak in error path Date: Thu, 6 Oct 2016 10:28:48 +0200 Message-Id: <20161006074731.888786896@linuxfoundation.org> X-Mailer: git-send-email 2.10.0 In-Reply-To: <20161006074731.150212126@linuxfoundation.org> References: <20161006074731.150212126@linuxfoundation.org> User-Agent: quilt/0.64 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 33 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Wahren commit 753246840d012ae34ea80a1d40bc1546c62fb957 upstream. In case of a IRQ type mismatch in of_pmu_irq_cfg() the device node for interrupt affinity isn't freed. So fix this issue by calling of_node_put(). Signed-off-by: Stefan Wahren Fixes: fa8ad7889d83 ("arm: perf: factor arm_pmu core out to drivers") Signed-off-by: Will Deacon Signed-off-by: Catalin Marinas Signed-off-by: Greg Kroah-Hartman --- drivers/perf/arm_pmu.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -815,6 +815,7 @@ static int of_pmu_irq_cfg(struct arm_pmu if (i > 0 && spi != using_spi) { pr_err("PPI/SPI IRQ type mismatch for %s!\n", dn->name); + of_node_put(dn); kfree(irqs); return -EINVAL; }