Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965835AbcJFJ2s (ORCPT ); Thu, 6 Oct 2016 05:28:48 -0400 Received: from mout.web.de ([217.72.192.78]:63717 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964918AbcJFJ2p (ORCPT ); Thu, 6 Oct 2016 05:28:45 -0400 Subject: [PATCH 28/54] md/raid5: Rename a jump label in setup_conf() To: linux-raid@vger.kernel.org, Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <2737d401-3606-d4c7-c930-5d7a425e5e84@users.sourceforge.net> Date: Thu, 6 Oct 2016 11:28:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3LMmKlmEiIRIrC76XG6XumucPfX4YKnD1cQ9wzMQ28CxcdPr1LO dZfDjY6ohXYSLwWfMHzNoZiG8GisgDKHAsGD3zBAERZkICgplejHFt3mV2i3LGROw3LCu9j DvSFSD3otFkejEoEd8bxl6LcRtpvdp3HbGl10Lk1Qv6DI5rr2Q++ok9JsXcSsC7/KR8kiju fyjDQDenaD5Vm3kKip9YQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:4AdKmg2/X7E=:c3i48vA3gg1Zw3f7Bur9Yk iarqFi8e62SUoRiujg2ttqqnTEXlZ3VaXrob/mfiyXcRczDtpq6R78m+BL/QbaMGNETPQ+ybk AM8CdACN3Vw/8Fb04uUGIHCl8g7pKmk+mmNSbM2jbAbhrIxkC9YJUJvi8U8iGRXbe7O8LEmK5 8ReDkYpGL1nf3QvJlJntSO6PlYkCDzIRTfhbjTVsz+YGg3Pg3kfGs7OASpJGGqkXkYXCpkbUu eyYX3zS91TzBWsKhuk5nQqiqV5vSXBB+NUS9Y1K/Fw6A/oNFGs5daARAFfW8BiF6FUC8p2//u tuWZ8EX3rMbTHZAY5sU95z+FmaI2JjEdYvMitC9BnbekrLMATcpJp3X3vIJshP8I5l201WIK7 s/CTxarqVkAZXeDtp14anH8pTJx0SNpEe6ph5avHfV++2MMLgNslCaiJ5Uwz9Y2Wk3gEOmMjR GfeIJX37i6gscoeLX9U0JRG0IoCJiD4dyR9152LQIJl6PAdfhptpo0N8YJ4e0yHAbN4T43T5b NiXSr0v83jzaXPEOHCQiQrTFFKDz5ANcfK8I3UIeLQvCnY1K+kJTqWjjNCQlIPFWa/w8ZI/jg egBQgJiRW1r7YJqU0jz4kSUXbj3Pv3oZWRzOI3T+xjwBw4goLMUwrFdYsSfAMPOIfx+ggIbUG mN5kxek07Kv8/XfjK/cHPFkp5mB/nFkETS6Eb6G8LuR1C3hWgZNKuZnPilkTwnPprZVDhHzya DfX3iv3wYfK+KZ3QizXZCyKhkpa3so0yo3UbuaRKRdaTYdi/3k3bYm+Ki6XUvO1FDJHJAg65S JGKEa9j Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2871 Lines: 100 From: Markus Elfring Date: Wed, 5 Oct 2016 08:18:38 +0200 Adjust jump labels according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/md/raid5.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 17f50a6..b624ba6 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -6490,8 +6490,10 @@ static struct r5conf *setup_conf(struct mddev *mddev) conf->group_cnt = group_cnt; conf->worker_cnt_per_group = worker_cnt_per_group; conf->worker_groups = new_group; - } else - goto abort; + } else { + goto free_conf; + } + spin_lock_init(&conf->device_lock); seqcount_init(&conf->gen_lock); mutex_init(&conf->cache_size_mutex); @@ -6518,12 +6520,12 @@ static struct r5conf *setup_conf(struct mddev *mddev) max_disks = max(conf->raid_disks, conf->previous_raid_disks); conf->disks = kcalloc(max_disks, sizeof(*conf->disks), GFP_KERNEL); if (!conf->disks) - goto abort; + goto free_conf; conf->mddev = mddev; if ((conf->stripe_hashtbl = kzalloc(PAGE_SIZE, GFP_KERNEL)) == NULL) - goto abort; + goto free_conf; /* We init hash_locks[0] separately to that it can be used * as the reference lock in the spin_lock_nest_lock() call @@ -6543,7 +6545,7 @@ static struct r5conf *setup_conf(struct mddev *mddev) conf->level = mddev->new_level; conf->chunk_sectors = mddev->new_chunk_sectors; if (raid5_alloc_percpu(conf) != 0) - goto abort; + goto free_conf; pr_debug("raid456: run(%s) called.\n", mdname(mddev)); @@ -6556,11 +6558,11 @@ static struct r5conf *setup_conf(struct mddev *mddev) if (test_bit(Replacement, &rdev->flags)) { if (disk->replacement) - goto abort; + goto free_conf; disk->replacement = rdev; } else { if (disk->rdev) - goto abort; + goto free_conf; disk->rdev = rdev; } @@ -6613,7 +6615,7 @@ static struct r5conf *setup_conf(struct mddev *mddev) printk(KERN_ERR "md/raid:%s: couldn't allocate %dkB for buffers\n", mdname(mddev), memory); - goto abort; + goto free_conf; } else printk(KERN_INFO "md/raid:%s: allocated %dkB\n", mdname(mddev), memory); @@ -6631,7 +6633,7 @@ static struct r5conf *setup_conf(struct mddev *mddev) printk(KERN_ERR "md/raid:%s: couldn't register shrinker.\n", mdname(mddev)); - goto abort; + goto free_conf; } sprintf(pers_name, "raid%d", mddev->new_level); @@ -6640,12 +6642,11 @@ static struct r5conf *setup_conf(struct mddev *mddev) printk(KERN_ERR "md/raid:%s: couldn't allocate thread.\n", mdname(mddev)); - goto abort; + goto free_conf; } return conf; - - abort: +free_conf: free_conf(conf); return ERR_PTR(-EIO); } -- 2.10.1