Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935957AbcJFKKP (ORCPT ); Thu, 6 Oct 2016 06:10:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51710 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbcJFKKN (ORCPT ); Thu, 6 Oct 2016 06:10:13 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Oct 2016 15:40:11 +0530 From: kgunda@codeaurora.org To: Stephen Boyd Cc: Mark Brown , Greg Kroah-Hartman , Sudip Mukherjee , linux-kernel@vger.kernel.org, aghayal@qti.qualcomm.com, adharmap@codeaurora.org Subject: Re: [PATCH] spmi: regmap: enable userspace writes Message-ID: User-Agent: Roundcube Webmail/1.2.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 19 On 2016-10-04 02:33, Stephen Boyd wrote: > On 09/30, kgunda@codeaurora.org wrote: >> On 2016-09-29 23:30, Mark Brown wrote: >> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: >> > >> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS >> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS >> > >> >This is completely inappropriate for upstream, if you need to do >> >debugging on your platform you can enable this locally but enabling >> >random writes from userspace to any regmap device is really not a good >> >idea for system stablity or robustness. >> >> Sure. I will remove this change and send the next version only to >> update >> the spmi device name. > > Why? The device name looks fine. Ok. I will re-check and ignore the patch, if no changes required.