Subject: Re: [PATCH 0/6] Start of skl watermark cleanup
To: Lyude <cpaul@redhat.com>, intel-gfx@lists.freedesktop.org
References: <1475681598-12081-1-git-send-email-cpaul@redhat.com>
Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Matt Roper <matthew.d.roper@intel.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Message-ID: <5d51cfd9-f500-c3f9-4d21-36a33051b5dd@linux.intel.com>
Date: Thu, 6 Oct 2016 13:25:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1475681598-12081-1-git-send-email-cpaul@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 528
Lines: 11

Op 05-10-16 om 17:33 schreef Lyude:
> While it (mostly) works, the code for handling watermarks on Skylake has been
> kind of ugly for a while. As well a lot of it isn't that friendly to atomic
> transactions, Lots of copy paste, redundant wm values, etc. While this isn't a
> full cleanup, it's a good start. As well, we add a couple of features for
> making debugging watermarks a little easier.
It's a good start, with the review comments addressed and rebased I think it's good to go. :)

Feel free to add my r-b.

~Maarten