Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941771AbcJFL56 (ORCPT ); Thu, 6 Oct 2016 07:57:58 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:33547 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755733AbcJFL5r (ORCPT ); Thu, 6 Oct 2016 07:57:47 -0400 Subject: Re: [PATCH V3 00/11] block-throttle: add .high limit To: Mark Brown , Linus Walleij References: <20161004155616.GB4205@htj.duckdns.org> <20161004162759.GD4205@htj.duckdns.org> <278BCC7B-ED58-4FDF-9243-FAFC3F862E4D@unimore.it> <20161004172852.GB73678@anikkar-mbp.local.dhcp.thefacebook.com> <20161004185413.GF4205@htj.duckdns.org> <20161004191427.GG4205@htj.duckdns.org> <20161006110342.gyyiwaqw4ivzdaww@sirena.org.uk> Cc: Tejun Heo , Paolo Valente , Shaohua Li , Vivek Goyal , linux-block@vger.kernel.org, "linux-kernel@vger.kernel.org" , Jens Axboe , Kernel-team@fb.com, jmoyer@redhat.com, Ulf Hansson , Hannes Reinecke From: "Austin S. Hemmelgarn" Message-ID: <439e8a13-cb14-c955-ae98-30ed5490739b@gmail.com> Date: Thu, 6 Oct 2016 07:57:37 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161006110342.gyyiwaqw4ivzdaww@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 32 On 2016-10-06 07:03, Mark Brown wrote: > On Thu, Oct 06, 2016 at 10:04:41AM +0200, Linus Walleij wrote: >> On Tue, Oct 4, 2016 at 9:14 PM, Tejun Heo wrote: > >>> I get that bfq can be a good compromise on most desktop workloads and >>> behave reasonably well for some server workloads with the slice >>> expiration mechanism but it really isn't an IO resource partitioning >>> mechanism. > >> Not just desktops, also Android phones. > >> So why not have BFQ as a separate scheduling policy upstream, >> alongside CFQ, deadline and noop? > > Right. > >> We're already doing the per-usecase Kconfig thing for preemption. >> But maybe somebody already hates that and want to get rid of it, >> I don't know. > > Hannes also suggested going back to making BFQ a separate scheduler > rather than replacing CFQ earlier, pointing out that it mitigates > against the risks of changing CFQ substantially at this point (which > seems to be the biggest issue here). > ISTR that the original argument for this approach essentially amounted to: 'If it's so much better, why do we need both?'. Such an argument is valid only if the new design is better in all respects (which there isn't sufficient information to decide in this case), or the negative aspects are worth the improvements (which is too workload specific to decide for something like this).