Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902AbcJFNJs (ORCPT ); Thu, 6 Oct 2016 09:09:48 -0400 Received: from smtp.math.uni-bielefeld.de ([129.70.45.10]:56907 "EHLO smtp.math.uni-bielefeld.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932720AbcJFNJi (ORCPT ); Thu, 6 Oct 2016 09:09:38 -0400 Subject: Re: [PATCH] exynos-drm: Fix error messages to print flags and size To: Shuah Khan , inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1470850236-9101-1-git-send-email-shuahkh@osg.samsung.com> From: Tobias Jakobi Message-ID: <57F64D0B.5050506@math.uni-bielefeld.de> Date: Thu, 6 Oct 2016 15:09:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <1470850236-9101-1-git-send-email-shuahkh@osg.samsung.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 37 Hello, I think this patch was never picked up. So just a short 'ping' from my side. With best wishes, Tobias Shuah Khan wrote: > Fix exynos_drm_gem_create() error messages to include flags and size when > flags and size are invalid. > > Signed-off-by: Shuah Khan > --- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c > index cdf9f1a..4c4cb0e 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c > @@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev, > int ret; > > if (flags & ~(EXYNOS_BO_MASK)) { > - DRM_ERROR("invalid flags.\n"); > + DRM_ERROR("invalid GEM buffer flags: %u\n", flags); > return ERR_PTR(-EINVAL); > } > > if (!size) { > - DRM_ERROR("invalid size.\n"); > + DRM_ERROR("invalid GEM buffer size: %lu\n", size); > return ERR_PTR(-EINVAL); > } > >