Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942050AbcJFOGu (ORCPT ); Thu, 6 Oct 2016 10:06:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33111 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932178AbcJFOGq (ORCPT ); Thu, 6 Oct 2016 10:06:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 4EF236044B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA To: Geert Uytterhoeven , "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1475762253-16759-1-git-send-email-geert@linux-m68k.org> From: Timur Tabi Message-ID: <57F65A73.7020701@codeaurora.org> Date: Thu, 6 Oct 2016 09:06:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <1475762253-16759-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 679 Lines: 17 Geert Uytterhoeven wrote: > config QCOM_EMAC > tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support" > + depends on HAS_DMA I think it needs to depend on HAS_IOMEM as well, to fix this error in arch/um: drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove': >> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] iounmap(adpt->phy.digital); -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.