Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755576AbcJFOK3 (ORCPT ); Thu, 6 Oct 2016 10:10:29 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:35316 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbcJFOKT (ORCPT ); Thu, 6 Oct 2016 10:10:19 -0400 MIME-Version: 1.0 In-Reply-To: <57F65A73.7020701@codeaurora.org> References: <1475762253-16759-1-git-send-email-geert@linux-m68k.org> <57F65A73.7020701@codeaurora.org> From: Geert Uytterhoeven Date: Thu, 6 Oct 2016 16:10:17 +0200 X-Google-Sender-Auth: 2Q2JPsVrOJDiX-SyWsJXm3J331c Message-ID: Subject: Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA To: Timur Tabi Cc: "David S. Miller" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 29 On Thu, Oct 6, 2016 at 4:06 PM, Timur Tabi wrote: > Geert Uytterhoeven wrote: >> >> config QCOM_EMAC >> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet >> support" >> + depends on HAS_DMA > > > I think it needs to depend on HAS_IOMEM as well, to fix this error in > arch/um: > > drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove': >>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit >>> declaration of function 'iounmap' [-Werror=implicit-function-declaration] > iounmap(adpt->phy.digital); Probably, I don't do UML allmodconfig builds. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds