Message-ID: <1475769143.1914.7.camel@perches.com>
Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit
 coding style issue
From: Joe Perches <coupons@perches.com>
To: Nadim Almas <nadim.902@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>
Cc: Lidza Louina <lidza.louina@gmail.com>, markh@compro.net,
        devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org
Date: Thu, 06 Oct 2016 08:52:23 -0700
In-Reply-To: <CANQNnfE2ha36bNd6yC+0CT=T5y86j3b_RhWu6ih4=c75o3qQwQ@mail.gmail.com>
References: <20161005215358.GA4231@gmail.com>
         <20161006052148.GA20295@kroah.com>
         <CANQNnfEB+KHRXkc6HpSqt6FcX6560juCybqSpuX6XpgsjxAaRg@mail.gmail.com>
         <CANQNnfE2ha36bNd6yC+0CT=T5y86j3b_RhWu6ih4=c75o3qQwQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2499
Lines: 65

On Thu, 2016-10-06 at 20:53 +0530, Nadim Almas wrote:
> May be it is not looking better than it did before but it removed 6 warning of
> the file which is shown by running "perl scripts/checkpatch.pl -f
> drivers/staging/dgnc/* | less" commend
> than why it is not acceptable

(please don't top post)

Because it's ugly and checkpatch output messages are not dicta.

If this is really useful, realign all the comments to start on
the same column.

more below...

> On Thu, Oct 6, 2016 at 1:52 PM, Nadim Almas <nadim.902@gmail.com> wrote:
> > May be it is not looking better than yours but it removed 6 warning of
> > the file which is shown by running "perl scripts/checkpatch.pl -f
> > drivers/staging/dgnc/* | less" commend
> > 
> > On Thu, Oct 6, 2016 at 10:51 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
> > > > Fixed coding style issue
> > > > 
> > > > Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> > > > ---
> > > >  drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
> > > >  1 file changed, 12 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
> > > > index abddd48..65994e3 100644
> > > > --- a/drivers/staging/dgnc/dgnc_neo.h
> > > > +++ b/drivers/staging/dgnc/dgnc_neo.h
> > > > @@ -30,7 +30,8 @@
> > > >  struct neo_uart_struct {O
> > > >       u8 txrx;                /* WR  RHR/THR - Holding Reg */
> > > >       u8 ier;         /* WR  IER - Interrupt Enable Reg */
> > > > -     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> > > > +     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
> > > > +                                                                     /*Reg */

Consider

12345678901234567890123456789012345678901234567890123456789012345678901234567890

struct neo_uart_struct {
	u8 txrx; 	/* WR  RHR/THR - Holding Reg */
	u8 ier;		/* WR  IER - Interrupt Enable Reg */
	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status & Fifo Control Reg */

or

struct neo_uart_struct {
	u8 txrx; 	/* WR  RHR/THR - Holding Reg */
	u8 ier;		/* WR  IER - Interrupt Enable Reg */
	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status Reg and
                         *               Fifo Control Reg
			 */

or

struct neo_uart_struct {
	u8 txrx; 	// WR  RHR/THR - Holding Reg
	u8 ier;		// WR  IER - Interrupt Enable Reg
	u8 isr_fcr;	// WR  ISR/FCR - Interrupt Status/Fifo Control Reg