Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942508AbcJFRW6 (ORCPT ); Thu, 6 Oct 2016 13:22:58 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36032 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942018AbcJFRWu (ORCPT ); Thu, 6 Oct 2016 13:22:50 -0400 Date: Thu, 6 Oct 2016 20:22:43 +0300 From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Markus Reichl , Tobias Jakobi , Michael Turquette , Stephen Boyd , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration Message-ID: <20161006172243.GA5229@kozik-lap> References: <1475765999-14366-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1475765999-14366-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 29 On Thu, Oct 06, 2016 at 11:59:59AM -0300, Javier Martinez Canillas wrote: > The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and > registration APIs") converted the driver to use the new provider API to > register clocks using clk_hw. > > But unfortunately, in the conversion it missed to set the num_clks value > which lead to the following error when trying to register a clk provider: > > [ 1.963782] of_clk_max77686_get: invalid index 0 > [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1) > [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock > > Fix it by correctly set the max77686_clk_driver_data num_clks member. > > Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs") > Reported-by: Markus Reichl > Suggested-by: Tobias Jakobi > Signed-off-by: Javier Martinez Canillas > Tested-by: Markus Reichl > > --- > > drivers/clk/clk-max77686.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof