Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbcJFRg6 (ORCPT ); Thu, 6 Oct 2016 13:36:58 -0400 Received: from smtprelay0001.hostedemail.com ([216.40.44.1]:55003 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752762AbcJFRgs (ORCPT ); Thu, 6 Oct 2016 13:36:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3873:3874:4321:5007:6119:6691:6742:7901:7903:10004:10400:10848:11026:11232:11658:11914:12296:12740:13069:13255:13311:13357:13439:13894:14181:14659:14721:21080:21212:21451:30012:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: soap99_3adeac2096e32 X-Filterd-Recvd-Size: 1970 Message-ID: <1475775403.1914.13.camel@perches.com> Subject: Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts() in raid5_status() From: Joe Perches To: SF Markus Elfring Cc: linux-raid@vger.kernel.org, Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Date: Thu, 06 Oct 2016 10:36:43 -0700 In-Reply-To: References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <92c52f1d-d151-cea6-e9ac-31378e6862d0@users.sourceforge.net> <1475771699.1914.10.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.0-2ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 14 On Thu, 2016-10-06 at 19:09 +0200, SF Markus Elfring wrote: > > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > > [] > > > @@ -7044,7 +7044,7 @@ static void raid5_status(struct seq_file *seq, struct mddev *mddev) > > > ? rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); > > > ? } > > > ? rcu_read_unlock(); > > > - seq_printf (seq, "]"); > > > + seq_puts(seq, "]"); > > seq_putc > How do you think about the possibility that the script "checkpatch.pl" can also point > such a source code transformation out directly? Why don't _you_ try to implement that in checkpatch instead?