Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933466AbcJFSGu (ORCPT ); Thu, 6 Oct 2016 14:06:50 -0400 Received: from mout.web.de ([212.227.15.4]:50058 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753941AbcJFSGj (ORCPT ); Thu, 6 Oct 2016 14:06:39 -0400 Subject: Re: md/raid10: Replace printk() calls by the usage of higher level interfaces To: Joe Perches References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <1475771616.1914.9.camel@perches.com> <321cc4aa-679a-a2fe-be0b-96285b19e489@users.sourceforge.net> <1475775546.1914.15.camel@perches.com> Cc: linux-raid@vger.kernel.org, Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <21fb08b6-d5b7-0dd6-0cbd-0f0a4bf56a9e@users.sourceforge.net> Date: Thu, 6 Oct 2016 20:04:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1475775546.1914.15.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:kMuEAp7vAy83TuYhKpOy6UtcVn/fCWoLPfLPCr6K9kFzUS7EHvE LCzmQ+G6q2anpvxXTDjkv4cXL+/YB+EQBP+5rG39uV2dnInGQwAFsTZFqJ33w1F2zx9JX2C YZx5N6DPYPqj97O5fbtbd7CwEGBTBOmZcJ8ZzqzWXpVW3/UNw31BG/J9owr+5mKh1/juA/p alLKly7Llp606JGc3AXWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wV0Yg0E/hPM=:3B6r0ldeQpLR5jWMXV+Nco b4HCKlXvEJ5E8nL5eJsepHyk18b0lvn82SqIdbJgxB39Ez255Iw29oXHc9pTBYEcfCh+fvvJ6 sm760TDduvKc6XnWyMGHhEn/LURjcCYrjaIvaqtuaF+QhJDdnCWXEIJa5XCwoKw1iBWHDsMY2 /LPXIKa5b2fEiKZGg5p0xLQSiBBE2UoxRDdyEEoti9umJwL50FEayCqhBRlT6DJLwzCzakpOm SFefkVv60AxRKBsvfPP3rlaY+HpIDha3HcoOIkSOlgKRI8c+BxwqRjZWl5hJfPn+pQBz2dbaM wQG74VmwrjJNvtGkneJQ4ps63xS6dYwc8DwmYoplOdV6DPLxFge59+RixStz9Ksi55PCV8uSe UqJbphAfK6K/YZU0DNHHf5FQrTxoKXn9XGxD2vYl81yqBQeC9UcMVHm4vJ5raOeR98GURmHGW cenHUz1D21UQONaqejdCYYfwRuRpdEkgsYMTqscBbvMBtgajUffm5Ikah8u7sSrEWulBhLIpc SsO8z3j06w9EC2z57yG97nzj6+FFkOgD2Y7U7zBBYvyFqm/Pt7rBDN0dEdBFItLqcmJxillZw nx648UvmvzW2DikJlynuoYtI2QMFegK4eFpdr8qRnxe4aLDCrAflH2i1pU9e5hW/Ttm7Wcrce t1VamMtlSS4wMTm3zbHwofkTPV+M+Izr9uB7RQ65C/qHx9lxLGDQqhYtjeFskzJnhkrokrz3R r+mScJ7i82wyHCNxvxGlABXs20i9EnC6EbJEzAndCOLoZWXJIBA2djwNv9K0e07Wr534aSY8W JBkgX81 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 18 >> How should a multiline log message be achieved as it was constructed >> in the function "raid10_error" (for example)? >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/md/raid10.c?id=c802e87fbe2d4dd58982d01b3c39bc5a781223aa#n1589 > > As two individual calls to pr_alert I know also such an approach. Would it be nicer if a single call will be sufficient for such a log message? Can an idea picked up which was discussed for the update suggestion "[PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()" for a moment (on 2016-09-24)? https://lkml.kernel.org/r/<1474735656.23838.6.camel@perches.com> https://lkml.org/lkml/2016/9/24/149 Regards, Markus