Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbcJFSXV (ORCPT ); Thu, 6 Oct 2016 14:23:21 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47500 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753618AbcJFSXN (ORCPT ); Thu, 6 Oct 2016 14:23:13 -0400 Date: Thu, 6 Oct 2016 20:23:03 +0200 From: Alexandre Belloni To: Icenowy Zheng Cc: Maxime Ripard , =?iso-8859-1?Q?Myl=E8ne?= Josserand , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-sunxi@googlegroups.com" , "thomas.petazzoni@free-electrons.com" , "vinod.koul@intel.com" , "linux-kernel@vger.kernel.org" , "mturquette@baylibre.com" , "tiwai@suse.com" , "sboyd@codeaurora.org" , "lgirdwood@gmail.com" , "robh+dt@kernel.org" , "perex@perex.cz" , "wens@csie.org" , "broonie@kernel.org" , "dmaengine@vger.kernel.org" , "lee.jones@linaro.org" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 06/14] ASoC: Add sun8i digital audio codec Message-ID: <20161006182303.sftz3c7hjhv7xell@piout.net> References: <85cbd9926e52d0aa03f6bbfd8794373d8db491e0.1475571575.git.mylene.josserand@free-electrons.com> <20161004161549.GO5228@lukather> <901741475770017@web21g.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <901741475770017@web21g.yandex.ru> User-Agent: NeoMutt/20160916 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 47 On 07/10/2016 at 00:06:57 +0800, Icenowy Zheng wrote : > 05.10.2016, 00:20, "Maxime Ripard" : > > Hi, > > > >> ?+static const struct of_device_id sun8i_codec_of_match[] = { > >> ?+ { .compatible = "allwinner,sun8i-a33-codec" }, > >> ?+ { .compatible = "allwinner,sun8i-a23-codec" }, > > > > I thought that the A23 and A33 had different codecs? In that case, it > > wouldn't be a good assumption to make > > Yes. > > > > >> ?+ {} > >> ?+}; > >> ?+MODULE_DEVICE_TABLE(of, sun8i_codec_of_match); > >> ?+ > >> ?+static struct platform_driver sun8i_codec_driver = { > >> ?+ .driver = { > >> ?+ .name = "sun8i-codec", > >> ?+ .owner = THIS_MODULE, > >> ?+ .of_match_table = sun8i_codec_of_match, > >> ?+ }, > >> ?+ .probe = sun8i_codec_probe, > >> ?+ .remove = sun8i_codec_remove, > >> ?+}; > >> ?+module_platform_driver(sun8i_codec_driver); > >> ?+ > >> ?+MODULE_DESCRIPTION("Allwinner A33 (sun8i) codec driver"); > >> ?+MODULE_AUTHOR("huanxin"); > > > > Those obfuscated email adresses are not really helpful :) > > This kind of email addresses are kept in many places in mainline kernel. > > e.g. drivers/mmc/host/sunxi-mmc.c have 'Aaron Maoye ' > Well, that is only one place and it is a comment, not in the MODULE_AUTHOR macro. I would agree that it is not useful to have a stale email address in MODULE_AUTHOR. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com