Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933838AbcJFTLS (ORCPT ); Thu, 6 Oct 2016 15:11:18 -0400 Received: from esgaroth.petrovitsch.at ([78.47.184.11]:2470 "EHLO esgaroth.tuxoid.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbcJFTLK (ORCPT ); Thu, 6 Oct 2016 15:11:10 -0400 X-Greylist: delayed 2160 seconds by postgrey-1.27 at vger.kernel.org; Thu, 06 Oct 2016 15:11:09 EDT Message-ID: <1475778808.2520.10.camel@petrovitsch.priv.at> Subject: Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts() in raid5_status() From: Bernd Petrovitsch To: SF Markus Elfring , Joe Perches Cc: linux-raid@vger.kernel.org, Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Date: Thu, 06 Oct 2016 20:33:28 +0200 In-Reply-To: References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <92c52f1d-d151-cea6-e9ac-31378e6862d0@users.sourceforge.net> <1475771699.1914.10.camel@perches.com> <1475775403.1914.13.camel@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-DCC-x.dcc-servers-Metrics: esgaroth.tuxoid.at 104; Body=13 Fuz1=13 Fuz2=13 X-Spam-Report: * 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 37 Hi all! On Thu, 2016-10-06 at 19:49 +0200, SF Markus Elfring wrote: > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > > > > [] > > > > > > > > > > @@ -7044,7 +7044,7 @@ static void raid5_status(struct > > > > > seq_file *seq, struct mddev *mddev) > > > > >      rdev && test_bit(In_sync, &rdev- > > > > > >flags) ? "U" : "_"); > > > > >   } > > > > >   rcu_read_unlock(); > > > > > - seq_printf (seq, "]"); > > > > > + seq_puts(seq, "]"); > > > > seq_putc > > > How do you think about the possibility that the script > > > "checkpatch.pl" can also point > > > such a source code transformation out directly? > > > > Why don't _you_ try to implement that in checkpatch instead? > > How are the chances that any other software developer would be > quicker (than me) for such > an addition because of more practical knowledge for the programming > language "Perl"? The above is BTW a pretty simple thing and thus good for a learning experience for regular expressions and copy-pasting a few lines in that perl-script and editing them. MfG, Bernd PS: Sry for the noise - it's somewhat OT here .... -- Bernd Petrovitsch Email : bernd@petrovitsch.priv.at LUGA : http://www.luga.at