Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934891AbcJFUQ3 (ORCPT ); Thu, 6 Oct 2016 16:16:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:56638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933172AbcJFUQW (ORCPT ); Thu, 6 Oct 2016 16:16:22 -0400 Date: Thu, 6 Oct 2016 17:07:23 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: sukadev@linux.vnet.ibm.com, jolsa@redhat.com, linux-kernel@vger.kernel.org, Andi Kleen , wangnan0@huawei.com Subject: Re: [PATCH 1/3] perf, tools: Handle events including .c and .o Message-ID: <20161006200723.GF4809@kernel.org> References: <1475696832-9188-1-git-send-email-andi@firstfloor.org> <1475696832-9188-2-git-send-email-andi@firstfloor.org> <20161005224706.GK30363@kernel.org> <20161006165504.GD26852@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161006165504.GD26852@two.firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 29 Em Thu, Oct 06, 2016 at 09:55:05AM -0700, Andi Kleen escreveu: > On Wed, Oct 05, 2016 at 07:47:06PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 05, 2016 at 12:47:10PM -0700, Andi Kleen escreveu: > > > From: Andi Kleen > > > > > > This is a generic bug fix, but it helps with Sukadev's JSON event tree > > > where such events can happen. > > > > > > Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading > > > and then an error. This can happen for some Intel JSON events, which cannot > > > be used. > > > > > > Fix the scanner to only match for .o or .c or .bpf at the end. > > > This will prevent loading multiple BPF scripts separated with comma, > > > but I assume this is acceptable. > > > > Wang, may I have your Acked-by, please? > > He acked it earlier here > > https://patchwork.kernel.org/patch/9337721/ > > Tested-by: Wang Nan Ok, will add the example where it breaks in the commit message, Thanks, - Arnaldo