Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527AbcJGBOG (ORCPT ); Thu, 6 Oct 2016 21:14:06 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43642 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935974AbcJGBNy (ORCPT ); Thu, 6 Oct 2016 21:13:54 -0400 Date: Thu, 06 Oct 2016 21:13:51 -0400 (EDT) Message-Id: <20161006.211351.701656198910382646.davem@davemloft.net> To: geert@linux-m68k.org Cc: timur@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM From: David Miller In-Reply-To: <1475765093-15536-1-git-send-email-geert@linux-m68k.org> References: <1475765093-15536-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Oct 2016 18:13:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u971EBw9022845 Content-Length: 1021 Lines: 25 From: Geert Uytterhoeven Date: Thu, 6 Oct 2016 16:44:53 +0200 > If NO_DMA=y: > > drivers/built-in.o: In function `emac_probe': > emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops' > emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops' > emac.c:(.text+0x378112): undefined reference to `bad_dma_ops' > emac.c:(.text+0x378146): undefined reference to `bad_dma_ops' > emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops' > drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow > > If NO_IOMEM=y: > > drivers/net/ethernet/qualcomm/emac/emac.c: In function ?emac_remove?: > drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ?iounmap? [-Werror=implicit-function-declaration] > iounmap(adpt->phy.digital); > ^ > > Add dependencies on HAS_DMA and HAS_IOMEM to fix this. > > Signed-off-by: Geert Uytterhoeven Applied.