Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935022AbcJGCAO (ORCPT <rfc822;w@1wt.eu>);
        Thu, 6 Oct 2016 22:00:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47310 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751233AbcJGCAG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 6 Oct 2016 22:00:06 -0400
Date: Fri, 7 Oct 2016 09:59:57 +0800
From: Dave Young <dyoung@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>, Tejun Heo <tj@kernel.org>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] Let CONFIG_STRICT_DEVMEM depends on CONFIG_DEVMEM
Message-ID: <20161007015957.GA9052@dhcp-128-65.nay.redhat.com>
References: <20161006051217.GA31027@dhcp-128-65.nay.redhat.com>
 <CAGXu5jJew=YK6FtE7itQJiuF46YHSvoaUFYPX6PNg9iH6UquiA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5jJew=YK6FtE7itQJiuF46YHSvoaUFYPX6PNg9iH6UquiA@mail.gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 07 Oct 2016 02:00:06 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1057
Lines: 39

On 10/06/16 at 02:39pm, Kees Cook wrote:
> On Wed, Oct 5, 2016 at 10:12 PM, Dave Young <dyoung@redhat.com> wrote:
> > With CONFIG_DEVMEM not set, CONFIG_STRICT_DEVMEM will be useless
> > even if it is set =y, thus let's update the dependency in Kconfig.
> >
> > Signed-off-by: Dave Young <dyoung@redhat.com>
> 
> Acked-by: Kees Cook <keescook@chromium.org>
> 
> > ---
> >  lib/Kconfig.debug |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-x86.orig/lib/Kconfig.debug
> > +++ linux-x86/lib/Kconfig.debug
> > @@ -1980,7 +1980,7 @@ config ARCH_HAS_DEVMEM_IS_ALLOWED
> >
> >  config STRICT_DEVMEM
> >         bool "Filter access to /dev/mem"
> > -       depends on MMU
> > +       depends on MMU && DEVMEM
> >         depends on ARCH_HAS_DEVMEM_IS_ALLOWED
> >         default y if TILE || PPC
> >         ---help---
> 
> While we're at it, can we make DEVKMEM default=n? The help text even
> suggests making it "n".

It's fine to me, will send another patch for that.

Thanks
Dave

> 
> -Kees
> 
> -- 
> Kees Cook
> Nexus Security