Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935171AbcJGDeA (ORCPT ); Thu, 6 Oct 2016 23:34:00 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33923 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935154AbcJGDdw (ORCPT ); Thu, 6 Oct 2016 23:33:52 -0400 Date: Fri, 7 Oct 2016 09:03:46 +0530 From: Viresh Kumar To: Markus Mayer Cc: Rob Herring , Mark Rutland , "Rafael J . Wysocki" , Broadcom Kernel List , Device Tree List , Power Management List , Linux Kernel Mailing List Subject: Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs Message-ID: <20161007033346.GA3954@vireshk-i7> References: <1475272561-8446-1-git-send-email-mmayer@broadcom.com> <1475272561-8446-3-git-send-email-mmayer@broadcom.com> <20161005032509.GG4664@vireshk-i7> <20161006040139.GA17619@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 18 On 06-10-16, 07:51, Markus Mayer wrote: > During early development, when the driver couldn't fully register, I > would see the init() function called four times, i.e. once for each > core. If the first call succeeded, that was it. It would only get > called once. But if it failed, all cores would try to register. And I > wanted to avoid spilling the same error message four times. This is the current behavior of the cpufreq core. > I'll look at that again. It may have had something to do with how the > driver worked back then. If it doesn't happen anymore, I'll just get > rid of this code. I don't think so, but again, we don't need to have special code to save few lines which get printed only in the rare case of errors. -- viresh