Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbcJGEE7 (ORCPT ); Fri, 7 Oct 2016 00:04:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48105 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbcJGEEs (ORCPT ); Fri, 7 Oct 2016 00:04:48 -0400 Date: Fri, 7 Oct 2016 05:57:19 +0200 From: Greg Kroah-Hartman To: Dave Young Cc: Arnd Bergmann , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: Change CONFIG_DEVKMEM default value to n Message-ID: <20161007035719.GB17183@kroah.com> References: <20161007020411.GB9052@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161007020411.GB9052@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 680 Lines: 26 On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote: > Kconfig comment suggests setting it as "n" if in doubt thus move the > default value to 'n'. > > Signed-off-by: Dave Young > Suggested-by: Kees Cook > --- > drivers/char/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-x86.orig/drivers/char/Kconfig > +++ linux-x86/drivers/char/Kconfig > @@ -17,7 +17,7 @@ config DEVMEM > > config DEVKMEM > bool "/dev/kmem virtual device support" > - default y > + default n If you remove the "default" line, it defaults to 'n'. And is it really "safe" to default this to n now? thanks, greg k-h