Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbcJGEoV (ORCPT ); Fri, 7 Oct 2016 00:44:21 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:33320 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbcJGEoO (ORCPT ); Fri, 7 Oct 2016 00:44:14 -0400 Date: Thu, 6 Oct 2016 21:27:36 -0700 From: Edward Lipinsky To: Greg KH Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, sudip@vectorindia.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning Message-ID: <20161007042736.GA18046@gmail.com> References: <20161002180505.GA19813@gmail.com> <20161002181301.GA22637@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161002181301.GA22637@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 35 On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > This patch fixes the checkpatch.pl warning: > > > > WARNING: printk() should include KERN_ facility level > > > > Signed-off-by: Edward Lipinsky > > --- > > drivers/staging/sm750fb/ddk750_help.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c > > index 9637dd3..e72a29c 100644 > > --- a/drivers/staging/sm750fb/ddk750_help.c > > +++ b/drivers/staging/sm750fb/ddk750_help.c > > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) > > devId750 = devId; > > revId750 = revId; > > if (revId == 0xfe) > > - printk("found sm750le\n"); > > + pr_info("found sm750le\n"); > > Why can't you use dev_info() here? > > thanks, > > greg k-h It should work, but I'm not sure what should change in the header files to do it--esp. to make the dev parameter available in ddk750_help.c. (Only sm750.c uses dev_ style logging now, the rest of the driver still uses pr_*.) Thanks, Ed Lipinsky