Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbcJGJHd (ORCPT ); Fri, 7 Oct 2016 05:07:33 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754208AbcJGJHW (ORCPT ); Fri, 7 Oct 2016 05:07:22 -0400 Subject: Re: md/raid1: Improve another size determination in setup_conf() To: SF Markus Elfring , Dan Carpenter References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <9831fce9-d689-89e4-dec8-50cadcd13fdd@users.sourceforge.net> <20161007075345.GB6039@mwanda> <77d68bcd-1ae4-4808-fc0b-6183ae5fb6c4@users.sourceforge.net> Cc: "linux-raid@vger.kernel.org" , Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall From: Richard Weinberger Message-ID: Date: Fri, 7 Oct 2016 11:06:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <77d68bcd-1ae4-4808-fc0b-6183ae5fb6c4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 33 On 07.10.2016 10:53, SF Markus Elfring wrote: >>>> Replace the specification of a data structure by a pointer dereference >>>> as the parameter for the operator "sizeof" to make the corresponding size >>>> determination a bit safer. >>> >>> Isn't this pure matter of taste? >>> Some developers prefer sizeof(*ptr) because it is easier to type, other >>> developers prefer sizeof(struct foo) because you can determine the type >>> at first sight and makes review more easy. >> >> sizeof(*ptr) is more future proof and normally more obvious and easier >> to review. > > Is it interesting to see how different the software development opinions > can be for such an implementation detail? > > >> That said, I've tried to tell Markus to only send bugfix patches > > Can any deviations from the Linux coding style become "bugs" also in > your view of the software situation? > > >> because these are a waste of time > > How do you value compliance with coding styles? Just stop sending these kind of patches, *please*. Linux has tons of issues, fixes for real problems are very welcome. But coding style bike shedding is just a waste of time. Thanks, //richard