Date: Fri, 7 Oct 2016 13:02:59 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Yinghai Lu <yinghai@kernel.org>
cc: Dou Liyang <douly.fnst@cn.fujitsu.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-tip-commits@vger.kernel.org" 
        <linux-tip-commits@vger.kernel.org>,
        Tony Luck <tony.luck@intel.com>
Subject: Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid
 <-> apicid mapping
In-Reply-To: <CAE9FiQVEvoK=TvYyhU6iiLh5FiX3pXXyy53tr2F7BEnRxGk7HA@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1610071302140.19804@nanos>
References: <1472114120-3281-4-git-send-email-douly.fnst@cn.fujitsu.com> <tip-8f54969dc8d6704632b42cbb5e47730cd75cc713@git.kernel.org> <CAE9FiQVQx6FRXT-RdR7Crz4dg5LeUWHcUSy1KacjR+JgU_vGJg@mail.gmail.com> <alpine.DEB.2.20.1610041258410.7712@nanos>
 <CAE9FiQWigWvrZ8JzNDKtZ9FWARh2m0kGoF+VOZdwAdY9vnU3_w@mail.gmail.com> <4608f474-c49e-550b-90e2-c5f4c25e00f5@cn.fujitsu.com> <CAE9FiQVEvoK=TvYyhU6iiLh5FiX3pXXyy53tr2F7BEnRxGk7HA@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 620
Lines: 21

On Thu, 6 Oct 2016, Yinghai Lu wrote:
> On Thu, Oct 6, 2016 at 1:06 AM, Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:
> Yes, that should work. but should do the same thing for x2apic
> 
> in acpi_parse_x2apic should have
> 
> > +       if (processor->local_apic_id == -1) {
> > +               ++disabled_cpus;
> > +               return -EINVAL;
> > +       }
> 
> that is the reason why i want to extend acpi_register_lapic()
> to take extra disabled_id (one is 0xff and another is 0xffffffff)
> so could save some lines.

That just makes the code harder to follow and is not really worth the
trouble.

Thanks,

	tglx