Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755068AbcJGLwm (ORCPT ); Fri, 7 Oct 2016 07:52:42 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:37521 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbcJGLwd (ORCPT ); Fri, 7 Oct 2016 07:52:33 -0400 Subject: Re: md/raid1: Improve another size determination in setup_conf() To: SF Markus Elfring References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <9831fce9-d689-89e4-dec8-50cadcd13fdd@users.sourceforge.net> <20161007075345.GB6039@mwanda> <77d68bcd-1ae4-4808-fc0b-6183ae5fb6c4@users.sourceforge.net> <522db506-1e1c-0563-7595-da6dc701d706@users.sourceforge.net> Cc: Dan Carpenter , Richard Weinberger , "linux-raid@vger.kernel.org" , Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall From: "Austin S. Hemmelgarn" Message-ID: <6e2c26bc-d765-6225-af72-157832ab8785@gmail.com> Date: Fri, 7 Oct 2016 07:52:22 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <522db506-1e1c-0563-7595-da6dc701d706@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 15 On 2016-10-07 06:50, SF Markus Elfring wrote: >> Linux has tons of issues, fixes for real problems are very welcome. > > Is a spectrum of software improvements to reconsider there? > > >> But coding style bike shedding is just a waste of time. > > Why do various software developers bother about coding style specifications > at all then? Coding style is important, but patches that just fix coding style are a bad thing because they break things like `git blame` and run the risk of introducing new bugs without any net benefit to end users. This goes double for code you don't actually work on regularly or don't completely understand.