Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756542AbcJGNV1 (ORCPT ); Fri, 7 Oct 2016 09:21:27 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:17027 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756492AbcJGNVT (ORCPT ); Fri, 7 Oct 2016 09:21:19 -0400 Message-ID: <57F7A14A.3070207@bfs.de> Date: Fri, 07 Oct 2016 15:21:14 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: kernel-janitors@vger.kernel.org CC: Dan Carpenter , linux-raid@vger.kernel.org, Guoqing Jiang , Shaohua Li , LKML , Julia Lawall Subject: Re: md-cluster: Delete unnecessary braces in unlock_all_bitmaps() References: <566ABCD9.1060404@users.sourceforge.net> <3a03df66-92ce-20fb-17f3-fb79b9d43c8e@users.sourceforge.net> <20161007074646.GA6039@mwanda> <9e1de37a-d98d-c885-b4ff-5a8b2aa1f7a8@users.sourceforge.net> In-Reply-To: <9e1de37a-d98d-c885-b4ff-5a8b2aa1f7a8@users.sourceforge.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 42 Am 07.10.2016 10:37, schrieb SF Markus Elfring: >>> Do not use curly brackets at one source code place >>> where a single statement should be sufficient. >> >> The original style was correct and this is wrong. I have explained this before. > > Did I change a bit too much in the proposed step according to the following > update suggestion? > > elfring@Sonne:~/Projekte/Linux/next-patched> git checkout d6385db94196b253ae5eb3678fa95cdf1f839fcc && scripts/checkpatch.pl --types BRACES -f drivers/md/md-cluster.c > … > WARNING: braces {} are not necessary for single statement blocks > #1228: FILE: drivers/md/md-cluster.c:1228: > + if (cinfo->other_bitmap_lockres[i]) { > + lockres_free(cinfo->other_bitmap_lockres[i]); > + } > … > > > How do you think about to adjust this source code place a bit? > perhaps we can agree to delete the if() block ? static void lockres_free(struct dlm_lock_resource *res) { int ret; if (!res) return; .... @marcus: is can not send mail to you sf.net adresse because sf.net mark my domain als spam (note: nobody else does) re, wh