Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757212AbcJGP3D (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Oct 2016 11:29:03 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:59695 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757264AbcJGP2l (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Oct 2016 11:28:41 -0400
Date: Fri, 7 Oct 2016 17:28:48 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Debjit Ghosh <dghosh@juniper.net>, Georgi Vlaev <gvlaev@juniper.net>,
        Guenter Roeck <linux@roeck-us.net>,
        Mohammad Kamil <mkamil@juniper.net>,
        Rajat Jain <rajatjain@juniper.net>,
        Shyamshankar Dharmarajan <shyamd@juniper.net>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 0/2] Juniper infrastructure
Message-ID: <20161007152848.GA10482@kroah.com>
References: <1475853346-21890-1-git-send-email-pantelis.antoniou@konsulko.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1475853346-21890-1-git-send-email-pantelis.antoniou@konsulko.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1852
Lines: 52

On Fri, Oct 07, 2016 at 06:15:44PM +0300, Pantelis Antoniou wrote:
> Introduce a staging driver containing all the bit and
> pieces of Juniper's board support infrastructure that don't quite
> fit in any other place.

Why staging?

> The Juniper series of routers comprise of both x86 and powerpc
> platforms that contain similar hardware components necessitating
> common support methods.
> 
> Note that this is the first submission and we expect things to be
> moved around as required.
> 
> This patchset is against mainline as of today: v4.8-9431-g3477d16
> and is dependent on the "Juniper prerequisites" patchset sent
> earlier.

sent where?  Why not just make a single patch series?

> Rajat Jain (1):
>   jnx: Introduce include/linux/jnx/pci_ids.h
> 
> Tom Kavanagh (1):
>   staging: jnx: Juniper subsystem & board core APIs
> 
>  Documentation/ABI/testing/sysfs-platform-jnx | 170 +++++++
>  drivers/staging/Kconfig                      |   2 +
>  drivers/staging/Makefile                     |   1 +
>  drivers/staging/jnx/Kconfig                  |  24 +
>  drivers/staging/jnx/Makefile                 |   5 +
>  drivers/staging/jnx/jnx-board-core.c         | 247 ++++++++++
>  drivers/staging/jnx/jnx-subsys-private.h     |  35 ++
>  drivers/staging/jnx/jnx-subsys.c             | 655 +++++++++++++++++++++++++++
>  include/linux/jnx/jnx-board-core.h           |  41 ++
>  include/linux/jnx/jnx-subsys.h               |  94 ++++
>  include/linux/jnx/pci_ids.h                  |  66 +++


staging drivers have to be self-contained, no files outside of your
subdirectory please.

Once they have "passed" proper review, then you can move files out.

Also, I need a TODO file listing what needs to be done, who to contact,
and other info about the code.

And again, why not just submit this to the real part of the kernel?

thanks,

greg k-h