Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964929AbcJGRHS (ORCPT ); Fri, 7 Oct 2016 13:07:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33502 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935466AbcJGRHJ (ORCPT ); Fri, 7 Oct 2016 13:07:09 -0400 Date: Fri, 7 Oct 2016 19:07:16 +0200 From: Greg KH To: Nadim Almas Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding Message-ID: <20161007170716.GB20665@kroah.com> References: <20161007154302.GA4331@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161007154302.GA4331@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 30 On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote: > style issue > > Fixed coding style issue This does not seem like valid sentances that mean much to me. Do they to you? > > Signed-off-by: Nadim Almas > --- > drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c > index 774b0ff..bc0c48f 100644 > --- a/drivers/staging/fbtft/fb_s6d02a1.c > +++ b/drivers/staging/fbtft/fb_s6d02a1.c > @@ -30,20 +30,27 @@ static int default_init_sequence[] = { > > -1, 0xfc, 0x5a, 0x5a, > > - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01, > + -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, > + 0x3A, 0x3A, 0x3d, 0x02, 0x01, This looks worse to me now, remember, checkpatch.pl is a "hint", not a hard-and-fast-rule. Use it wisely. greg k-h