Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941219AbcJGRH5 (ORCPT ); Fri, 7 Oct 2016 13:07:57 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38905 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932268AbcJGRHu (ORCPT ); Fri, 7 Oct 2016 13:07:50 -0400 MIME-Version: 1.0 In-Reply-To: <20161007035719.GB17183@kroah.com> References: <20161007020411.GB9052@dhcp-128-65.nay.redhat.com> <20161007035719.GB17183@kroah.com> From: Kees Cook Date: Fri, 7 Oct 2016 10:02:24 -0700 X-Google-Sender-Auth: 2epxi4Lq0PFDXA-OKZcfEQv5QPM Message-ID: Subject: Re: Change CONFIG_DEVKMEM default value to n To: Greg Kroah-Hartman Cc: Dave Young , Arnd Bergmann , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 34 On Thu, Oct 6, 2016 at 8:57 PM, Greg Kroah-Hartman wrote: > On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote: >> Kconfig comment suggests setting it as "n" if in doubt thus move the >> default value to 'n'. >> >> Signed-off-by: Dave Young >> Suggested-by: Kees Cook >> --- >> drivers/char/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-x86.orig/drivers/char/Kconfig >> +++ linux-x86/drivers/char/Kconfig >> @@ -17,7 +17,7 @@ config DEVMEM >> >> config DEVKMEM >> bool "/dev/kmem virtual device support" >> - default y >> + default n > > If you remove the "default" line, it defaults to 'n'. > > And is it really "safe" to default this to n now? This is DEVKMEM which distros haven't (shouldn't have?) used for a while now. I'm not so bold as to suggest making DEVMEM default-n yet. ;) -Kees -- Kees Cook Nexus Security