Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941359AbcJGRL4 (ORCPT ); Fri, 7 Oct 2016 13:11:56 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34361 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934666AbcJGRLt (ORCPT ); Fri, 7 Oct 2016 13:11:49 -0400 Subject: Re: [PATCH/RFT 11/12] ARM: dts: da850: Add the usb ohci device node To: ahaslam@baylibre.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, nsekhar@ti.com, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com, david@lechnology.com References: <1475858577-10366-1-git-send-email-ahaslam@baylibre.com> <1475858577-10366-12-git-send-email-ahaslam@baylibre.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <7227c5ff-4f9e-bcb5-ea0f-cdd122d42445@cogentembedded.com> Date: Fri, 7 Oct 2016 20:11:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475858577-10366-12-git-send-email-ahaslam@baylibre.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 30 Hello. On 10/07/2016 07:42 PM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > This adds the device tree node for the usb11 (ohci) > controller present in the da850 family of SoC's. > > Signed-off-by: Axel Haslam > --- > arch/arm/boot/dts/da850.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 33fcdce..afae565 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -381,6 +381,14 @@ > #phy-cells = <1>; > status = "disabled"; > }; > + usb11: usb11@0225000 { No, usb@ to comply with the DT spec the node names should be generic. [...] MBR, Sergei