Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754817AbcJGSJJ (ORCPT ); Fri, 7 Oct 2016 14:09:09 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:37046 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbcJGSI7 (ORCPT ); Fri, 7 Oct 2016 14:08:59 -0400 Date: Fri, 7 Oct 2016 10:02:14 -0700 From: Guenter Roeck To: Steve Twiss Cc: Wim Van Sebroeck , Lee Jones , Dmitry Torokhov , Eduardo Valentin , Zhang Rui , DEVICETREE , LINUX-INPUT , LINUX-PM , Liam Girdwood , Mark Brown , Mark Rutland , Rob Herring , Support Opensource , LINUX-KERNEL , LINUX-WATCHDOG Subject: Re: [PATCH V1 04/10] watchdog: da9061: watchdog driver (RFC) Message-ID: <20161007170214.GA21349@roeck-us.net> References: <6ED8E3B22081A4459DAC7699F3695FB7018CCE242C@SW-EX-MBX02.diasemi.com> <20161006184927.GB11915@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7018CCE2732@SW-EX-MBX02.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7018CCE2732@SW-EX-MBX02.diasemi.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2080 Lines: 48 On Fri, Oct 07, 2016 at 02:56:17PM +0000, Steve Twiss wrote: > On 06 October 2016 19:49, Guenter Roeck wrote: > > Subject: Re: [PATCH V1 04/10] watchdog: da9061: watchdog driver (RFC) > > > > Hi Steve, > > [...] > > > On Thu, Oct 06, 2016 at 04:28:14PM +0000, Steve Twiss wrote: > > > I am using the compatible string to pick a different configuration .data block: > > > > > > { .compatible = "dlg,da9062-watchdog", .data = &da9062_watchdog_info }, > > > { .compatible = "dlg,da9061-watchdog", .data = &da9061_watchdog_info }, > > > > > > when the only real difference between the DA9061 and DA9062 watchdog driver > > > is the name. Functionally they are identical in this case. > [...] > > > This exact same thing would happen with da9063-onkey and da9062-thermal also. > > > For the ONKEY it is marginally confused by needing to support 63, but for 62 and 61 > > > it is the same thing. Only the name is different. > > > > [...] > > > But, it is just my opinion to keep the "name" different. > > > This will not be my decision if accepted into the Linux kernel, but I would like to > > > at least be consistent for DA9061 and DA9062 so ... is this an issue? > > > > > > Yes, for me it is. The driver is still the same, and I don't see the point > > of increasing code size and making the driver less readable just to be able > > to report a slightly different driver identification string. And each time > > a similar HW is added we would go through the same effort, again for no > > good reason. > > > > My reason for doing this was to report the hardware identification, not the > driver name. But, there would certainly be a lot less to do if I was to make > DA9061 core use the DA9062 watchdog. > > > FWIW the driver doesn't really need to be updated in the first place. > > A compatible statement listing both da9061 and da9062 would do it. > > I will make the changes you requested: deprecate the existing compatibility > for da9062-watchdog and make a new compatibility string which combines both > da9061 and da9062. > That is not what I asked for. Guenter