Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249AbcJGSzZ (ORCPT ); Fri, 7 Oct 2016 14:55:25 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:36184 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbcJGSzR (ORCPT ); Fri, 7 Oct 2016 14:55:17 -0400 MIME-Version: 1.0 In-Reply-To: <20161007170716.GB20665@kroah.com> References: <20161007154302.GA4331@gmail.com> <20161007170716.GB20665@kroah.com> From: Nadim Almas Date: Sat, 8 Oct 2016 00:25:15 +0530 Message-ID: Subject: Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding To: Greg KH Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1406 Lines: 37 why its seems worst to you i am just removing "80 character line limit coding style" for the last 3 months I am trying to submit my first patch but patch is not accepted by you by giving reason i can't able to understand please help me On Fri, Oct 7, 2016 at 10:37 PM, Greg KH wrote: > On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote: >> style issue >> >> Fixed coding style issue > > This does not seem like valid sentances that mean much to me. Do they > to you? > >> >> Signed-off-by: Nadim Almas >> --- >> drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++---------- >> 1 file changed, 20 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c >> index 774b0ff..bc0c48f 100644 >> --- a/drivers/staging/fbtft/fb_s6d02a1.c >> +++ b/drivers/staging/fbtft/fb_s6d02a1.c >> @@ -30,20 +30,27 @@ static int default_init_sequence[] = { >> >> -1, 0xfc, 0x5a, 0x5a, >> >> - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01, >> + -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, >> + 0x3A, 0x3A, 0x3d, 0x02, 0x01, > > This looks worse to me now, remember, checkpatch.pl is a "hint", not a > hard-and-fast-rule. Use it wisely. > > greg k-h