Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 27 Mar 2003 15:38:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 27 Mar 2003 15:38:34 -0500 Received: from mail2.sonytel.be ([195.0.45.172]:53979 "EHLO mail.sonytel.be") by vger.kernel.org with ESMTP id ; Thu, 27 Mar 2003 15:38:32 -0500 Date: Thu, 27 Mar 2003 21:49:23 +0100 (MET) From: Geert Uytterhoeven To: Antonino Daplas cc: James Simmons , Linux Kernel Mailing List , Linux Fbdev development list Subject: Re: [Linux-fbdev-devel] Framebuffer fixes. In-Reply-To: <1048792155.1109.29.camel@localhost.localdomain> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1897 Lines: 50 On 28 Mar 2003, Antonino Daplas wrote: > On Thu, 2003-03-27 at 17:09, Geert Uytterhoeven wrote: > > On 27 Mar 2003, Antonino Daplas wrote: > > > - image->depth should be representative of the data depth > > > (currently, either 8 or 1). If image->depth == 1, color expansion can > > > now be used to draw the logo, thus there's no need to differentiate > > > between mono logo drawing and monochrome expansion. > > > > > + /* > > > + * Monochrome expansion and logo drawing functions are the same if > > > + * fb_logo.needs_logo == 1. > > > + */ > > > + switch (info->fix.visual) { > > > + case FB_VISUAL_MONO10: > > > + image.fg_color = (u32) (~(~0UL << fb_logo.depth)); > > ^^^^^^^^^^^^^ > > > + image.bg_color = 0; > > > + image.depth = 1; > > > + break; > > > + case FB_VISUAL_MONO01: > > > + image.bg_color = (u32) (~(~0UL << fb_logo.depth)); > > ^^^^^^^^^^^^^ > > > + image.fg_color = 0; > > > + image.depth = 1; > > > + break; > > > > Shouldn't these be info->var.bits_per_pixel instead of fb_logo.depth? > > Yes, fb_logo.depth == info->var.bits_per_pixel. Euh, now I get confused... Do you mean `Yes, it should be replaced by info->var.bits_per_pixel' or `No, logo.depth is always equal to info->var.bits_per_pixel'? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/