Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755351AbcJGUNo (ORCPT ); Fri, 7 Oct 2016 16:13:44 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:32999 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755185AbcJGUNg (ORCPT ); Fri, 7 Oct 2016 16:13:36 -0400 MIME-Version: 1.0 In-Reply-To: <1475870688.1945.13.camel@perches.com> References:

<1475870688.1945.13.camel@perches.com> From: Linus Torvalds Date: Fri, 7 Oct 2016 13:13:35 -0700 X-Google-Sender-Auth: IS40Pn2tSp4N0xM6r5NBf8t2BnM Message-ID: Subject: Re: [GIT PULL] trivial for 4.9 To: Joe Perches Cc: Jiri Kosina , Colin Ian King , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 20 On Fri, Oct 7, 2016 at 1:04 PM, Joe Perches wrote: > > Any printk without a KERN_ prefix, and there > are still many of those, can cause random interleaving. How about people actually work on *that* instead of working around it? Because the above really should not be true. > Not at all. Until printk KERN_ uses are mandated, > then these newlines are still useful. The patches literally added those '\n' things to the pr_xyz() routines that *enforce* KERN_. So really. It's a step backwards. We shouldn't need them. We should *remove* '\n' at the end, and then if that actually causes problems, we should fix those problems. Linus