Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932701AbcJGU0Y (ORCPT ); Fri, 7 Oct 2016 16:26:24 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21419 "EHLO sender163-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754394AbcJGU0Q (ORCPT ); Fri, 7 Oct 2016 16:26:16 -0400 Message-ID: <1475871962.1697.12.camel@mniewoehner.de> Subject: Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422 From: Michael =?ISO-8859-1?Q?Niew=F6hner?= To: Felipe Balbi Cc: Vivek Gautam , Alim Akhtar , Pankaj Dubey , Anand Moon , Mathias Nyman , Greg Kroah-Hartman , Kukjin Kim , Krzysztof Kozlowski , Linux USB Mailing List , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Vivek Gautam In-Reply-To: <87y420wqoy.fsf@linux.intel.com> References: <1472414695.3845.3.camel@mniewoehner.de> <87lgzgdof3.fsf@linux.intel.com> <57C41582.1030604@linux.intel.com> <1472468730.4925.3.camel@mniewoehner.de> <1475578687.1912.28.camel@mniewoehner.de> <1475771380.22019.5.camel@mniewoehner.de> <87y420wqoy.fsf@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 07 Oct 2016 22:26:02 +0200 Mime-Version: 1.0 X-Mailer: Evolution 3.20.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u97KQRlC027544 Content-Length: 4703 Lines: 80 Hi Felipe, On Fr, 2016-10-07 at 10:42 +0300, Felipe Balbi wrote: > Hi, > > Michael Niewöhner writes: > > > > > > > > The clocks are same across working/non-working. > > > Is it possible to bisect the commit that's causing hang for 4.8x ? > > > > > > [c499ff71ff2a281366c6ec7a904c547d806cbcd1] usb: dwc3: core: re-factor init and exit paths > > This patch causes both the hang on reboot and the lsusb hang. > > How to reproduce? Why don't we see this on x86 and TI boards? I'm > guessing this is failed bisection, as I can't see anything in that > commit that would cause reboot hang. Also, that code path is *NOT* > executed when you run lsusb. > I've tested this procedure multiple times to be sure: - checkout c499ff71, compile, boot the odroid - run lsusb -v => lsusb hangs, can't terminate with ctrl-c - hard reset, after boot run poweroff or reboot => board does not completely power off / reboot (see log below) - revert c499ff71, mrproper, compile, boot the odroid - run lsusb -v => shows full output, not hanging - run reboot or poweroff => board powers off / reboots just fine dmesg poweroff not working: ... [  120.733519] systemd-journald[144]: systemd-journald stopped as pid 144        [  120.742663] systemd-shutdown[1]: Sending SIGKILL to remaining processes...    [  120.769212] systemd-shutdown[1]: Unmounting file systems.                     [  120.773713] systemd-shutdown[1]: Unmounting /sys/kernel/debug.                [  120.827211] systemd-shutdown[1]: Unmounting /dev/mqueue.                      [  121.081672] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     [  121.091687] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     [  121.095608] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     [  121.101014] systemd-shutdown[1]: All filesystems unmounted.                   [  121.106523] systemd-shutdown[1]: Deactivating swaps.                          [  121.111585] systemd-shutdown[1]: All swaps deactivated.                       [  121.116661] systemd-shutdown[1]: Detaching loop devices.                      [  121.126395] systemd-shutdown[1]: All loop devices detached.                   [  121.130525] systemd-shutdown[1]: Detaching DM devices.                        [  121.135824] systemd-shutdown[1]: All DM devices detached.                     [  121.166327] systemd-shutdown[1]: /lib/systemd/system-shutdown succeeded.      [  121.171739] systemd-shutdown[1]: Powering off. => at this point removing the sd card would show a message  "removed mmc0" (not sure what the real message was...) so the board is not completely off. dmesg poweroff working: ... [  120.733519] systemd-journald[144]: systemd-journald stopped as pid 144        [  120.742663] systemd-shutdown[1]: Sending SIGKILL to remaining processes...    [  120.769212] systemd-shutdown[1]: Unmounting file systems.                     [  120.773713] systemd-shutdown[1]: Unmounting /sys/kernel/debug.                [  120.827211] systemd-shutdown[1]: Unmounting /dev/mqueue.                      [  121.081672] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     [  121.091687] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     [  121.095608] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     [  121.101014] systemd-shutdown[1]: All filesystems unmounted.                   [  121.106523] systemd-shutdown[1]: Deactivating swaps.                          [  121.111585] systemd-shutdown[1]: All swaps deactivated.                       [  121.116661] systemd-shutdown[1]: Detaching loop devices.                      [  121.126395] systemd-shutdown[1]: All loop devices detached.                   [  121.130525] systemd-shutdown[1]: Detaching DM devices.                        [  121.135824] systemd-shutdown[1]: All DM devices detached.                     [  121.166327] systemd-shutdown[1]: /lib/systemd/system-shutdown succeeded.      [  121.171739] systemd-shutdown[1]: Powering off. [  121.182331] rebo� Best regards Michael